Changes for adding Cameras beyond LSTCam and NectarCam #29
Conversation
…tion) - This corrects wrong values for LST and MST-Nectar - Iteration numbers are printed up to 10 events, and then every 10 events (if debug=True)
tstolarczyk
changed the title
| thresholds: # picture, boundary | ||
| - LSTCam: [6, 3] | ||
| - NectarCam: [8, 4] # TBC | ||
| - FlashCam: [0,0] |
There was a problem hiding this comment.
won't that accept all pixels? Later, it's set to [8,4], so should at least be consistent.
There was a problem hiding this comment.
Yes, I agree, otherwise, the two cleanings will not be equivalent as it is now (even though we don't know for sure if they should). Regarding their precise values, I don't think is important for the moment since they can be changed anyway by the user.
| ievt+=1 | ||
| if (debug): | ||
| if (ievt< 10) or (ievt%10==0) : print(ievt) | ||
|
|
There was a problem hiding this comment.
Perhaps it is better to put the increment inside the conditional block, so we avoid to do it also when debug is False
| thresholds: # picture, boundary | ||
| - LSTCam: [6, 3] | ||
| - NectarCam: [8, 4] # TBC | ||
| - FlashCam: [0,0] |
There was a problem hiding this comment.
Yes, I agree, otherwise, the two cleanings will not be equivalent as it is now (even though we don't know for sure if they should). Regarding their precise values, I don't think is important for the moment since they can be changed anyway by the user.
New config file to test beyond LSTCam and NectarCam cameras based on prod3b files